CI: Require TOML to be formatted#104
Open
ilya-bobyr wants to merge 2 commits intosolana-program:mainfrom
Open
Conversation
ilya-bobyr
force-pushed
the
pr/format-toml
branch
from
8425f50 to
6bb1d0f
Compare
ilya-bobyr
force-pushed
the
pr/format-toml
branch
3 times, most recently
from
7670435 to
995ac78
Compare
tombi is a pretty good TOML formatter/LSP with support for TOML in general, and Rust Cargo.toml in particular. Using a unified format is nice. In particular, tombi sorts not just properties within a section, but also sections and tables. Apparently some TOML parsers may fail if tables are not correctly sorted.
This is just a formatting change. Reproduce by running: ```bash tombi format program tombi format clients/rust tombi format pinocchio/program tombi format pinocchio/interface tombi format interface ```
ilya-bobyr
force-pushed
the
pr/format-toml
branch
from
995ac78 to
04e115e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tombi is a pretty good TOML formatter/LSP with support for TOML in general, and Rust Cargo.toml in particular.
Using a unified format is nice.
In particular, tombi sorts not just properties within a section, but also sections and tables. Apparently some TOML parsers may fail if tables are not correctly sorted.